Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added proper alias checks to the match implementations of parametrized types #242

Merged
merged 3 commits into from
Feb 13, 2024
Merged

added proper alias checks to the match implementations of parametrized types #242

merged 3 commits into from
Feb 13, 2024

Conversation

jurgenvinju
Copy link
Member

@github-actions GitHub Actions
Copy link

Test Results

     96 files  ±0       96 suites  ±0   7m 28s ⏱️ - 1m 3s
242 291 tests ±0  242 290 ✅ ±0  1 💤 ±0  0 ❌ ±0 
726 960 runs  ±0  726 957 ✅ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit 818c500. ± Comparison against base commit dada98d.

DavyLandman
DavyLandman approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@DavyLandman DavyLandman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jurgenvinju
Copy link
Member Author

added some failing tests to make sure we don't regress.

@jurgenvinju
Copy link
Member Author

Still thinking about tuples..

@jurgenvinju jurgenvinju merged commit 6c9ac23 into main Feb 13, 2024
7 checks passed
@jurgenvinju jurgenvinju deleted the fix-for-rascal-issue-1812 branch February 13, 2024 16:25
@jurgenvinju jurgenvinju self-assigned this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavyLandman DavyLandman DavyLandman approved these changes

Assignees

@jurgenvinju jurgenvinju

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jurgenvinju @DavyLandman